Skip to content

ART-14816: Add Containerfile.art for ART builds#151

Open
shruti-rh wants to merge 4 commits into
openshift:release-1.1from
shruti-rh:release-1.1
Open

ART-14816: Add Containerfile.art for ART builds#151
shruti-rh wants to merge 4 commits into
openshift:release-1.1from
shruti-rh:release-1.1

Conversation

@shruti-rh

@shruti-rh shruti-rh commented Jun 9, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

Problem Statement

ART needs to build external-secrets-operator images through its Konflux-based layered products pipeline. ART builds require a dedicated Containerfile.art with ART's builder images, base images, and LABEL conventions.

Related Issue

Part of ART-14816 (Onboard OAP operators to ART) and ART-14821 (Onboard External Secrets Operator to ocp-build-data).

Proposed Changes

  • Add Containerfile.art to the release-1.1 branch
  • Uses ART's golang builder (brew.registry.redhat.io/rh-osbs/openshift-golang-builder)
  • Uses ubi9/ubi-minimal as runtime base image
  • Includes required Red Hat container LABELs (com.redhat.component, name, cpe, etc.)
  • Exists alongside the existing Dockerfile without modifying it

Note: Bundle Containerfile is not included in this PR — the OLM bundle is handled separately via update-csv in ART's build pipeline using the bundle/art.yaml and bundle/image-references files (already merged).

fbladilo and others added 3 commits April 7, 2026 16:52
@fbladilo
Add Containerfile.art for ART builds
df3af0f 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@fbladilo
Add art.yaml and image-references
bfd494c 
- ART tooling reqs

Signed-off-by: Franco Bladilo <fbladilo@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@bharath-b-rh @shruti-rh
NO-JIRA: Fix vendor file tracking and Makefile bootstrap on clean che…
c69fff6 
…ckouts

Signed-off-by: Bharath B <bhb@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 9, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@shruti-rh: This pull request references ART-14816 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2f874762-94d9-47fa-b864-88f4257ff843

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from TrilokGeer and mytreya-rh June 9, 2026 05:59
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 9, 2026
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

Hi @shruti-rh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ashwindasr

ashwindasr commented Jun 9, 2026

Copy link
Copy Markdown

/hold

Let me take a look as well

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2026
@ashwindasr

ashwindasr commented Jun 9, 2026

Copy link
Copy Markdown

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2026
bharath-b-rh
bharath-b-rh reviewed Jun 30, 2026
View reviewed changes

@bharath-b-rh bharath-b-rh left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Could you please commit the changes again, for the commit to be get the verified tag. Also please add description to the PR.

We don't have a Containerfile added for bundle in this PR. Will that be in a follow up?

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2026
@bharath-b-rh

bharath-b-rh commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2026
@shruti-rh
Fix Containerfile.art to use Doozer-provided build version
fcc9d37 
ART/Doozer injects BUILD_VERSION and SOURCE_GIT_COMMIT as ENV
variables during rebase, not RELEASE_VERSION/COMMIT_SHA ARGs
which are Konflux Tekton-specific. Use bash default syntax to
support both build systems.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Shruti Anekar <sanekar@redhat.com>
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2026
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shruti-rh
Once this PR has been reviewed and has the lgtm label, please ask for approval from bharath-b-rh. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shruti-rh

shruti-rh commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

We don't have a Containerfile added for bundle in this PR. Will that be in a follow up?

@bharath-b-rh ART handles bundle generation differently. Instead of a separate Containerfile,
ART uses:

  • update-csv in the operator's ocp-build-data image YAML
  • bundle/art.yaml for string replacements
  • bundle/image-references for mapping image pullspecs

Doozer is a tool that generates the bundle automatically during the operator build's rebase step. So there's no need for a separate bundle Containerfile.art.

@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

@shruti-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mytreya-rh mytreya-rh Awaiting requested review from mytreya-rh
@TrilokGeer TrilokGeer Awaiting requested review from TrilokGeer
1 more reviewer
@bharath-b-rh bharath-b-rh bharath-b-rh left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@bharath-b-rh bharath-b-rh

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shruti-rh @openshift-ci-robot @ashwindasr @bharath-b-rh @fbladilo